-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Kimera on SpecLog #357
Conversation
DEFINE_string(params_folder_path, "../params/Euroc", | ||
DEFINE_string(params_folder_path, "/home/ekf/software/robot/data/iphoneSpectacularParams", | ||
"Path to the folder containing the yaml files with the VIO parameters."); | ||
DEFINE_string(dataset_path, "/Users/Luca/data/MH_01_easy", | ||
"Path of dataset (i.e. Euroc, /Users/Luca/data/MH_01_easy)."); | ||
DEFINE_string(dataset_path, "/home/ekf/software/robot/data/Walk-to-work", | ||
// DEFINE_string(dataset_path, "/home/ekf/software/robot/data/20241212_090634", | ||
"Path of dataset"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using the cxxopts library to handle argument flags. Up to you if you want to switch to that. Here is an example:
cxxopts::Options options("cfr_train", "I wanna be the very best, like no one ever was."); |
I see that this isn't a cc_test
. Is there something that is making it difficult to do that instead? I could imagine it being useful to have a binary to run Kimera on some log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately cxxopts and google flags don't play well together, we would likely have to add a bandaid or remove all gflags from used kimera components.
Re cc_test
vs cc_binary
-- I picked cc_binary because I thought it would be useful to have a binary to run on logs. If we change it to a cc_test would we still be able to use it to get vio solutions from different bags?
I can make it a test and make sure the final pose is somewhat reasonable. Where should I put the iphone spectacular params? (this repo, pulled in as a zip, standalone repo?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in another pr break out an interface to create and run pipeline on a spec log. Create a test that uses this, and use this interface in the binary as well.
add working script to run kimera vio on a spectacularlog